[CLN-list] workaround in cl_nt_sqrtmodp.cc for gcc 3.5 branch?

[Ralf Wildenhues]

Hi there,

With a recent gcc HEAD CVS snapshot (which I came to try out because of
gcc regression debug/16035 found during compilation of cln) linking
against libcln.so fails with

gcc-test/bin/g++ -g -O2 exam.o exam_I.o exam_RA.o exam_SF.o exam_FF.o exam_DF.o exam_LF.o exam_I_gcd.o exam_I_sqrtp.o -o .libs/exam  ../src/.libs/libcln.so -lgmp -lm -Wl,--rpath -Wl,/usr/local/lib
../src/.libs/libcln.so: undefined reference to `cln::tonelli_shanks_sqrt(cln::cl_modint_ring const&, cln::cl_MI const&)::cl_sylow2gen_property::~cl_sylow2gen_property()'
../src/.libs/libcln.so: undefined reference to `cln::tonelli_shanks_sqrt(cln::cl_modint_ring const&, cln::cl_MI const&)::cl_sylow2gen_property::~cl_sylow2gen_property()'

Reversing the logic of the two #if's in src/numtheory/cl_nt_sqrtmodp.cc,
which seem to guard against a gcc-2 bug on s390, compilation succeeds
and `make check' passes (no further tests done).  This is on linux/x86
with no configuration options except setting CC and CXX.

Now I'd like to know if this a sign of yet another gcc regression before
reporting it?

Regards,
Ralf