[GiNaC-devel] [PATCH 5/6] ncmul::eval(): don't write beyond the end of the vector.
Jens Vollinga
jensv at nikhef.nl
Mon Aug 10 11:23:11 CEST 2009
Hi Alexei,
Alexei Sheplyakov schrieb:
> rettypes.reserve(assocseq.size());
> // rettypes.size() == 0 since reserve() does NOT change the size of a vector.
> rettypes[i] = cit->return_type();
> // Illegal according to the standard. Appears to work with some implementations
> // and segfault with others (i.e. m$vc)
>
> So the patch does fix the access beyond the vector boundary (as the commit
> message implies).
oops, yes, sorry, I was confusing reserve with resize ...
Thanks for all the patches. Is there something else you would want to
see in 1.5.4? Otherwise I'll do a release soon.
Regards,
Jens
More information about the GiNaC-devel
mailing list