[GiNaC-devel] Wrong patch (Was: Fix unsigned character bugs in ginac-1.5.8)

[Alexei Sheplyakov]

Hello,

On Sat, Apr 02, 2011 at 12:08:24PM +0200, Martin Guy wrote:

> This patch fixes a bug on machines where char is unsigned by default, by
> extending the type of clifford_max_label to include all 257 possible
> return values.

I'm sorry to confuse you, but your patch is wrong. It just breaks ABI for
nothing good at all. In practice there's no need for gamma matrices with
128 representation labels (otherwise GiNaC would have problems on machines
where char is *signed* by default). I guess we should fix the documentation
(it claims that representation labels from 0 to 255 are supported, which
is definitely wrong).

Best regards,
	Alexei