[GiNaC-devel] RFC: step function and Pauli matrices

[Richard B. Kreckel]

Hi Matthias,

On 12/20/2013 03:21 PM, Matthias Dellweg wrote:
> GiNaC is able to check whether expressions are sums of possymbols. We
> can use that to evaluate some step functions immediately:
> 	0001-Evaluate-step-whenever-possible.patch
> This should be a generic transformation from an integral with a step
> function to step functions times integrals without:
> 	0002-Integrate-when-integrand-is-a-product-with-a-step-fu.patch
> This patch implements Pauli matrices in the same manner as in color.cpp
> (shamelessly borrowed...):
> 	0003-Implementation-of-Pauli-matrices.patch
> As opposed to the color algebra, a product of pauli objects can always
> be reduced to a linear combination of single pauli objects:
> 	0004-New-function-pauli_normalize.patch

I've had a quick look at your patches.

The first two are lightweight and appear rather harmless, but they both
introduce new functionality and should come with a test case.

The third and fourth patch introduces Pauli matrices, they should not
only come with extra test cases, but also with good documentation.

If you intend to resubmit your patches, please also add comments in the
preferred git format, so that they can be readily applied.

  -richy.
-- 
Richard B. Kreckel
<http://www.ginac.de/~kreckel/>