From jrheinlaender at gmx.de  Sun Jul  1 17:00:12 2018
From: jrheinlaender at gmx.de (=?UTF-8?Q?Jan_Rheinl=c3=a4nder?=)
Date: Sun, 1 Jul 2018 17:00:12 +0200
Subject: [GiNaC-devel] CLN and GiNaC patches for Win64 build
In-Reply-To: <a6f4342f-f819-d73f-8b75-fcbc441a66f7@in.terlu.de>
References: <CADe39dpr=oRRegOaZULenhUHQbHav3WwK-0vEnXiA2Exy+Lw2g@mail.gmail.com>
 <CADNgsy2K4yopb3de0Kf_ANfhjy_e+snxDnEsX2NmxbGJdararQ@mail.gmail.com>
 <FB7ADB0D-E070-43A1-9686-7A8C36FAC416@gmail.com>
 <20120813072917.GB10841@vargsbox.jinr.ru>
 <98D1EEE2-439A-4619-AE67-8ADD6D6B30A2@gmail.com>
 <20120814194242.GA5039@vargsbox.jinr.ru>
 <999C378C-1529-4FC9-8EA5-64BED35F179E@gmail.com>
 <CADe39dqhsbtq1DuuR2EfdrbwrQBS-g31rGDQM9ZgMRy50osiAg@mail.gmail.com>
 <7ade4d46-1c08-adc7-3d9c-b88e5c5be269@gmx.de>
 <6a66faac-e056-7314-58f2-ffbe695ef4b3@in.terlu.de>
 <a7e7ce25-8c6c-08c7-3e28-17a46498af3c@gmx.de>
 <a6f4342f-f819-d73f-8b75-fcbc441a66f7@in.terlu.de>
Message-ID: <4b9e9afe-4666-cdc5-e4f8-dedc881c0735@gmx.de>

Hi,

the patch is on

https://github.com/jrheinlaender/ginac/commit/d87445c0eaa27669f82bea19bb69933c3e66b9a1


Am 04.05.2018 um 23:38 schrieb Richard B. Kreckel:
> On 05/02/2018 08:22 PM, Jan Rheinl?nder wrote:
>> here's what the compiler says (sorry my system is German):
>>
>> factor.cpp(2254): error C2440: "Initialisierung": "std::size_t" kann
>> nicht in "GiNaC::numeric" konvertiert werden
>> factor.cpp(2254): note: Quelltyp konnte von keinem Konstruktor
>> angenommen werden, oder die ?berladungsaufl?sung des Konstruktors ist
>> mehrdeutig
>>
>> The code in line 2254 is:
>>
>> numeric modulus = (vnlst.nops() > 3) ? vnlst.nops() : 3;
>>
>> It initializes a numeric from the return value of nops(), which is size_t.
> So on Windos, where unsigned int is the same as unsigned long, the two
> existing overloads of numeric ctor are ambiguous. Bummer.
>
> It's better to convert these prototypes to uint32_t, uint64_t from
> <cstdint> than add more overloads for size_t. This way, we need to
> maintain two overloads, rather than three.
>
>   -richy.
> _______________________________________________
> GiNaC-devel mailing list
> GiNaC-devel at ginac.de
> https://www.cebix.net/mailman/listinfo/ginac-devel