[GiNaC-devel] Sqrfree_parfrac Issue GiNaC

[Vladimir V. Kisil]

________________________________________
From: GiNaC-devel <ginac-devel-bounces at ginac.de> on behalf of Richard B. Kreckel <kreckel at in.terlu.de>
Sent: 27 July 2020 18:51
To: ginac-devel at ginac.de
Subject: Re: [GiNaC-devel] Sqrfree_parfrac Issue GiNaC

Vladimir,

On 24.07.20 00:08, Vladimir V. Kisil wrote:
> Many thanks for reporting the bug with a detailed description. I am attaching a patch to fix it.

Thanks very much for your patch. It seems fine to me, I've only one
question: You copied the comment about Yun's algorithm from the
sqrfree() function. But does the last sentence ("For completeness, we'll
also have to recurse...") really apply here? As far as I can see, it
should be removed.

You are correct, Richard! I am attaching the updated patches.

 Vladimir
_______________________________________________
GiNaC-devel mailing list
GiNaC-devel at ginac.de
https://www.ginac.de/mailman/listinfo/ginac-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-of-a-bug-in-sqrfree_parfrac-related-to-Yun-facto.patch
Type: text/x-patch
Size: 4139 bytes
Desc: 0001-Fix-of-a-bug-in-sqrfree_parfrac-related-to-Yun-facto.patch
URL: <http://www.ginac.de/pipermail/ginac-devel/attachments/20200727/9650c95d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-the-bug-in-power-expand-with-the-overall-coeffic.patch
Type: text/x-patch
Size: 2510 bytes
Desc: 0002-Fix-the-bug-in-power-expand-with-the-overall-coeffic.patch
URL: <http://www.ginac.de/pipermail/ginac-devel/attachments/20200727/9650c95d/attachment-0001.bin>