[GiNaC-list] factor() hangs on a simple expression, randomly

[Richard B. Kreckel]

Hi Vitaly,

On 12/13/2017 05:05 PM, Vitaly Magerya wrote:
> One potential risk I see is if you factor() each of the pre-existing
> factors separately, then identical factors of each part may not get
> re-combined properly. Not that current factor() ever provided such a
> guarantee. I also can't seem to find a good counter-example, so maybe
> it's a non-issue.

The automatic .eval() thing should take care of this situation and
re-combine identical factors.

>> Can you try to send a patch?
>> I'ld be happy to review it and help, but have not the time to do it
>> myself, I'm afraid.
> 
> I'm attaching a brute force approach, see if you like it. (Does this
> list accept attachments?).

Thanks a lot for the patch! I see that the comment of the factor()
function is now outdated. Would you like to fix the comment before I
push the patch?

All my best,
   -richy.
-- 
Richard B. Kreckel
<https://in.terlu.de/~kreckel/>