* Implementation of GiNaC's sums of expressions. */
/*
- * GiNaC Copyright (C) 1999-2007 Johannes Gutenberg University Mainz, Germany
+ * GiNaC Copyright (C) 1999-2008 Johannes Gutenberg University Mainz, Germany
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
#include <iostream>
#include <stdexcept>
+#include <limits>
+#include <string>
#include "add.h"
#include "mul.h"
if (precedence() <= level)
c.s << "(";
- // Print arguments, separated by "+"
+ // Print arguments, separated by "+" or "-"
epvector::const_iterator it = seq.begin(), itend = seq.end();
+ char separator = ' ';
while (it != itend) {
- // If the coefficient is -1, it is replaced by a single minus sign
- if (it->coeff.is_equal(_ex1)) {
+ // If the coefficient is negative, separator is "-"
+ if (it->coeff.is_equal(_ex_1) ||
+ ex_to<numeric>(it->coeff).numer().is_equal(*_num_1_p))
+ separator = '-';
+ c.s << separator;
+ if (it->coeff.is_equal(_ex1) || it->coeff.is_equal(_ex_1)) {
it->rest.print(c, precedence());
- } else if (it->coeff.is_equal(_ex_1)) {
- c.s << "-";
+ } else if (ex_to<numeric>(it->coeff).numer().is_equal(*_num1_p) ||
+ ex_to<numeric>(it->coeff).numer().is_equal(*_num_1_p))
+ {
it->rest.print(c, precedence());
- } else if (ex_to<numeric>(it->coeff).numer().is_equal(*_num1_p)) {
- it->rest.print(c, precedence());
- c.s << "/";
- ex_to<numeric>(it->coeff).denom().print(c, precedence());
- } else if (ex_to<numeric>(it->coeff).numer().is_equal(*_num_1_p)) {
- c.s << "-";
- it->rest.print(c, precedence());
- c.s << "/";
+ c.s << '/';
ex_to<numeric>(it->coeff).denom().print(c, precedence());
} else {
it->coeff.print(c, precedence());
- c.s << "*";
+ c.s << '*';
it->rest.print(c, precedence());
}
- // Separator is "+", except if the following expression would have a leading minus sign or the sign is sitting in parenthesis (as in a ctor)
++it;
- if (it != itend
- && (is_a<print_csrc_cl_N>(c) || !it->coeff.info(info_flags::real) // sign inside ctor arguments
- || !(it->coeff.info(info_flags::negative) || (it->coeff.is_equal(*_num1_p) && is_exactly_a<numeric>(it->rest) && it->rest.info(info_flags::negative)))))
- c.s << "+";
+ separator = '+';
}
if (!overall_coeff.is_zero()) {
int add::degree(const ex & s) const
{
- int deg = INT_MIN;
+ int deg = std::numeric_limits<int>::min();
if (!overall_coeff.is_zero())
deg = 0;
int add::ldegree(const ex & s) const
{
- int deg = INT_MAX;
+ int deg = std::numeric_limits<int>::max();
if (!overall_coeff.is_zero())
deg = 0;
epvector v;
v.reserve(seq.size());
for (epvector::const_iterator i=seq.begin(); i!=seq.end(); ++i)
- if ((i->coeff).info(info_flags::real))
- v.push_back(expair((i->rest).real_part(), i->coeff));
- else {
+ if ((i->coeff).info(info_flags::real)) {
+ ex rp = (i->rest).real_part();
+ if (!rp.is_zero())
+ v.push_back(expair(rp, i->coeff));
+ } else {
ex rp=recombine_pair_to_ex(*i).real_part();
- v.push_back(split_ex_to_pair(rp));
+ if (!rp.is_zero())
+ v.push_back(split_ex_to_pair(rp));
}
return (new add(v, overall_coeff.real_part()))
-> setflag(status_flags::dynallocated);
epvector v;
v.reserve(seq.size());
for (epvector::const_iterator i=seq.begin(); i!=seq.end(); ++i)
- if ((i->coeff).info(info_flags::real))
- v.push_back(expair((i->rest).imag_part(), i->coeff));
- else {
+ if ((i->coeff).info(info_flags::real)) {
+ ex ip = (i->rest).imag_part();
+ if (!ip.is_zero())
+ v.push_back(expair(ip, i->coeff));
+ } else {
ex ip=recombine_pair_to_ex(*i).imag_part();
- v.push_back(split_ex_to_pair(ip));
+ if (!ip.is_zero())
+ v.push_back(split_ex_to_pair(ip));
}
return (new add(v, overall_coeff.imag_part()))
-> setflag(status_flags::dynallocated);