]> www.ginac.de Git - ginac.git/log
ginac.git
14 years agoFix dangerous iterator use.
Richard Kreckel [Tue, 18 May 2010 22:18:35 +0000 (00:18 +0200)]
Fix dangerous iterator use.

This was detected by cppcheck and reported by Martin Ettl <ettl.martin@gmx.de>.

14 years agopgcd(), chinrem_gcd(): use appropriate definition of the degree.
Alexei Sheplyakov [Mon, 17 May 2010 22:23:03 +0000 (00:23 +0200)]
pgcd(), chinrem_gcd(): use appropriate definition of the degree.

Effect: fixes (rare) GCD miscalculation.

pgcd() treats polynomials Z_p[x_0, ..., x_n] as R[x_0, ..., x_{n - 1}], where
R = Z_p[x_n]. Therefore one should use correct definition of the degree
(i.e. compute it w.r.t. x_0, ..., x_{n-1}, but NOT w.r.t. x_n!).

One should use appropriate definition of degree (that is, w.r.t.  x_0, ..., x_n)
in chinrem_gcd() too.

Thanks to Aless Lasaruk for a bug report.

14 years agoAdded `degree_vector' utility function.
Alexei Sheplyakov [Mon, 17 May 2010 22:21:53 +0000 (00:21 +0200)]
Added `degree_vector' utility function.

It's a generalization of degree(expr, var) for multivariate polynomials.

14 years agoprimpart_content: correctly handle monomials.
Alexei Sheplyakov [Mon, 17 May 2010 22:20:08 +0000 (00:20 +0200)]
primpart_content: correctly handle monomials.

Impact: fixes (rare) incorrect gcd calculation and (potential) segfault.

Thanks to Aless Lasaruk for a bug report.

14 years agopgcd(): avoid infinite loop if the first GCD candidate coincides with GCD
Alexei Sheplyakov [Mon, 17 May 2010 22:17:26 +0000 (00:17 +0200)]
pgcd(): avoid infinite loop if the first GCD candidate coincides with GCD

136 if (H_lcoeff.is_equal(lc_gcd)) {
137 if ((Hprev-H).expand().smod(pn).is_zero()) // (*)
138 continue;

The check (*) can result in infinite loop if the (very) first GCD candidate
gives the correct GCD: any subsequent iterations give the same result, so
Hprev and H will be equal (hence the infinite loop). That check is not very
useful (AFAIR I was trying to avoid extra division checks), so let's remove it.

14 years agoFix URL of CODA.
Richard Kreckel [Mon, 17 May 2010 06:37:08 +0000 (08:37 +0200)]
Fix URL of CODA.

14 years agoFix memory leak in excompiler due to use of wrong operator delete.
Richard Kreckel [Thu, 13 May 2010 20:54:52 +0000 (22:54 +0200)]
Fix memory leak in excompiler due to use of wrong operator delete.

This was reported by Martin Ettl <ettl.martin@gmx.de>.

14 years agoExplicit function disambiguation.
Richard Kreckel [Thu, 13 May 2010 16:30:40 +0000 (18:30 +0200)]
Explicit function disambiguation.

This is necessary for compilers where the hyperbolic and the tgamma function
templates are pulled in from <cmath> and compete with GiNaC's function
templates. GCC 4.4 and 4.5 need this, when compiling with -std=cxx0x.

14 years agoFix weird ctor invocation syntax.
Richard Kreckel [Tue, 27 Apr 2010 20:44:35 +0000 (22:44 +0200)]
Fix weird ctor invocation syntax.

This patch is required for GCC-4.5.

14 years agoProducts (class mul) now answer correctly to info_flags::negative and
Jens Vollinga [Sun, 28 Mar 2010 22:21:18 +0000 (00:21 +0200)]
Products (class mul) now answer correctly to info_flags::negative and
info_flags::negint.

14 years agoReally fixed the atan2(-Pi, 0) bug.
Richard Kreckel [Thu, 25 Mar 2010 22:08:54 +0000 (23:08 +0100)]
Really fixed the atan2(-Pi, 0) bug.

The problem was that atan2_eval assumed that if y is real and not
positive, it must be negative. But this neglects the fact that in
symbolic compution it may just not be possible to determine the
sign. Now, the expression is returned as it is. Ugly, but correct.

14 years agoMerge branch 'master' of ssh://www.ginac.de/srv/git/ginac
Richard Kreckel [Thu, 25 Mar 2010 21:23:13 +0000 (22:23 +0100)]
Merge branch 'master' of ssh://www.ginac.de/srv/git/ginac

14 years agoFixed a bug in atan2. It gave a division by zero error for calls like
Jens Vollinga [Thu, 25 Mar 2010 09:36:41 +0000 (10:36 +0100)]
Fixed a bug in atan2. It gave a division by zero error for calls like
atan2(-Pi,0), because arguments like -Pi were not recognized (via
info_flags) as negative but as real nevertheless.

14 years agoCopyright goes 2010.
Jens Vollinga [Fri, 5 Mar 2010 20:37:19 +0000 (21:37 +0100)]
Copyright goes 2010.

14 years agoUpdate copyright notice.
Richard Kreckel [Sat, 27 Feb 2010 14:00:22 +0000 (15:00 +0100)]
Update copyright notice.

14 years agopgcd(): detect relatively prime polynomials properly...
Alexei Sheplyakov [Tue, 23 Feb 2010 10:01:23 +0000 (12:01 +0200)]
pgcd(): detect relatively prime polynomials properly...

... so pgcd() doesn't loop forever any more. Division test does not handle
relatively prime polynomials (because C = 1 divides any polynomial). So we
should stop interpolation (and return gcd of contents) if we got relatively
prime images (we should do that for efficiency reasons too).

Thanks to Jörg Arndt for a bug report.

14 years agoInstall the ginac-excompiler script iff excompiler is supported and enabled.
Alexei Sheplyakov [Wed, 6 Jan 2010 17:56:04 +0000 (19:56 +0200)]
Install the ginac-excompiler script iff excompiler is supported and enabled.

15 years agoFix libtool versioning fiasco.
Richard Kreckel [Wed, 4 Nov 2009 20:58:26 +0000 (21:58 +0100)]
Fix libtool versioning fiasco.

Fix f2f67dde5c9caca, which caused the soname to be bumped too frequently.

15 years agoAdd mul::info() and add::info() support for numeric info_flags.
Richard Kreckel [Sun, 11 Oct 2009 21:19:21 +0000 (23:19 +0200)]
Add mul::info() and add::info() support for numeric info_flags.

This way, GiNaC knows that the sum or product of a number of positive
expressions is again a positive expression. [by Vladimir Kisil]

15 years agoOutput LaTeX-symbols using \mathrm, instead of \mbox.
Richard Kreckel [Sun, 4 Oct 2009 20:30:45 +0000 (22:30 +0200)]
Output LaTeX-symbols using \mathrm, instead of \mbox.

Using \mathrm improves printing in complex formulae.
One reason is that it scales in fractions. [by Vladimir Kisil]

15 years agoRemove debian/ directory.
Richard Kreckel [Tue, 29 Sep 2009 20:25:16 +0000 (22:25 +0200)]
Remove debian/ directory.

The lifecycle of the Debian packaging files is better maintained in
the Debian pool's diff file. Removing these files makes the life of
the GiNaC releaser easier.

15 years agoProperly document how to deal with libtool versioning.
Richard Kreckel [Tue, 29 Sep 2009 20:08:11 +0000 (22:08 +0200)]
Properly document how to deal with libtool versioning.

The old description was referring to ginac_lt_age which should always
stay 0, because we promised to mark incompatible binary interfaces by
bumping ginac_minor_version (or even ginac_major_version). Let's get
rid of ginac_lt_age.

15 years agomodular_matrix: don't use STL iterators in {mul, sub}_col and friends.
Alexei Sheplyakov [Sat, 8 Aug 2009 10:03:15 +0000 (13:03 +0300)]
modular_matrix: don't use STL iterators in {mul, sub}_col and friends.

Not using STL iterators makes the code simpler and cleaner. Also we don't
have to argue whether the standard ([lib.random.access.iterators]) imposes
any pre/post-condictions on operator+=.

15 years agoshaker_sort, permutation_sign: fix invalid use of STL iterators.
Alexei Sheplyakov [Sat, 8 Aug 2009 10:03:48 +0000 (13:03 +0300)]
shaker_sort, permutation_sign: fix invalid use of STL iterators.

According to the standard incrementing end(), and decrementing begin()
are ill-defined operations (see [lib.forward.iterators],
[lib.bidirectional.iterators]).

15 years agosymmetry::calchash(): be careful to not dereference past-the-end iterator.
Alexei Sheplyakov [Sat, 8 Aug 2009 10:07:14 +0000 (13:07 +0300)]
symmetry::calchash(): be careful to not dereference past-the-end iterator.

15 years agocheck_parameter_G: fix pontential increment of end().
Alexei Sheplyakov [Sat, 8 Aug 2009 10:06:36 +0000 (13:06 +0300)]
check_parameter_G: fix pontential increment of end().

Incrementing past-the-end iterator is not permitted by the standard, see
[lib.input.iterators].

15 years agoG_eval: fix incorrect use of STL iterator.
Alexei Sheplyakov [Sat, 8 Aug 2009 10:02:47 +0000 (13:02 +0300)]
G_eval: fix incorrect use of STL iterator.

According to [lib.bidirectional.iterators] it's not OK to decrement
an iterator pointing to the beginning of the sequence. Fortunately random
access iterators provided by (current versions of) gcc/libstdc++ don't have
this silly limitation, so the code which works with pointers works with
iterators without any changes at all. However,
 - there's no guarantee that the current behavior won't change in the future
 - some non-GNU compilers are not that smart (i.e. the program segfaults
   upon when decrementing beginning-of-the-sequence iterator).

15 years agoAllow underscores in identifiers.
Jens Vollinga [Wed, 15 Jul 2009 03:19:07 +0000 (05:19 +0200)]
Allow underscores in identifiers.

15 years agoChanged the parser such that it understands all defined functions
Jens Vollinga [Fri, 10 Jul 2009 13:01:04 +0000 (15:01 +0200)]
Changed the parser such that it understands all defined functions
including the user defined ones.

To this end a method has been added to class function to allow the
modified get_default_reader() function to build up a complete prototype
table. The autogen tool is no longer required.

15 years agoFixed manual to correctly explain return_type_tinfo().
Jens Vollinga [Fri, 10 Jul 2009 07:54:09 +0000 (09:54 +0200)]
Fixed manual to correctly explain return_type_tinfo().

15 years agoRaised required version of CLN to 1.2.2.
Jens Vollinga [Wed, 10 Jun 2009 09:28:34 +0000 (11:28 +0200)]
Raised required version of CLN to 1.2.2.

15 years agoAdded include for cstdio header.
Jens Vollinga [Fri, 24 Apr 2009 21:37:44 +0000 (23:37 +0200)]
Added include for cstdio header.
gcc 4.0 does not include cstdio as part of other headers like string
anymore. As a result, gcc 4.0 complained about EOF being undefined.

15 years agocalchash(): work around broken RTTI.
Alexei Sheplyakov [Mon, 23 Feb 2009 12:08:42 +0000 (14:08 +0200)]
calchash(): work around broken RTTI.

Due to the strange (although permitted by the standard) behaviour of C++
RTTI on woe32 calchash() returns different hash values for equal objects.
As a result automatic evaluation gets spectacularly broken:

examining clifford objects.....({1+t,2+x,3+y,4+z}) - ({1+t,2+x,3+y,4+z}) erroneously returned -{1+t,2+x,3+y,4+z}+{1+t,2+x,3+y,4+z} instead of 0
({1+t,2+x,3+y,4+z}) - ({1+t,2+x,3+y,4+z}) erroneously returned -{1+t,2+x,3+y,4+z}+{1+t,2+x,3+y,4+z} instead of 0
.({1+t,2+x,3+y,4+z}) - ({1+t,2+x,3+y,4+z}) erroneously returned -{1+t,2+x,3+y,4+z}+{1+t,2+x,3+y,4+z} instead of 0
({1+t,2+x,3+y,4+z}) - ({1+t,2+x,3+y,4+z}) erroneously returned {1+t,2+x,3+y,4+z}-{1+t,2+x,3+y,4+z} instead of 0
[skipped]
.......FAIL: exam_clifford.exe

This patch works around `features' of woe32 RTTI, so calchash() works
properly.

15 years agoFix compilation failure due to (template) operator- defined in factor.cpp
Alexei Sheplyakov [Mon, 23 Feb 2009 12:03:16 +0000 (14:03 +0200)]
Fix compilation failure due to (template) operator- defined in factor.cpp

GiNaC 1.5.0 fails to compile with g++ 3.4.
The fix is simple: declare (and define) operator- (and operator+) only
for (univariate) polynomials.

15 years agoUnivariate GCD timing: use sr_gcd when appropriate. release_1-5-0
Alexei Sheplyakov [Mon, 16 Feb 2009 14:23:16 +0000 (16:23 +0200)]
Univariate GCD timing: use sr_gcd when appropriate.

The benchmark consists of two parts:
1) timing of different GCD calculation methods (i.e. subresultant PRS,
   heuristic, chinese remaindering).
2) timing of different implementations of the same method. The purpose
   is to find out how (in)efficient GiNaC::ex is as a representation
   of (univariate) polynomials (as a side note, the result is a bit
   depressing -- using coefficient vector instead of GiNaC:ex makes
   GCD calculation 50x -- 1000x faster).

Now GiNaC uses modular (chinese remaindering) GCD by default, so part 2)
got broken, i.e. instead of (intended) timings

a) (heuristic, GiNaC::ex) versus (heuristic, coefficient vector)
b) (PRS, GiNaC::ex) versus (PRS, coefficient vector)

one gets

a') (heuristic, GiNaC::ex) versus (heuristic, coefficient vector)
b') (chinese remaindering, GiNaC::ex) versus (PRS, coefficient vector)

Set the gcd_options::use_sr_gcd to restore the meaning of the benchmark.

Note: this patch does not affect the library proper.

15 years agoPolished NEWS a little bit.
Alexei Sheplyakov [Mon, 16 Feb 2009 14:24:15 +0000 (16:24 +0200)]
Polished NEWS a little bit.

15 years agoAdded release date.
Jens Vollinga [Tue, 17 Feb 2009 13:38:17 +0000 (14:38 +0100)]
Added release date.

15 years agoAdjusted NEWS and INSTALL documentation.
Jens Vollinga [Fri, 6 Feb 2009 15:49:47 +0000 (16:49 +0100)]
Adjusted NEWS and INSTALL documentation.

15 years agoMissed to change one date in function.pl.
Jens Vollinga [Fri, 6 Feb 2009 15:35:22 +0000 (16:35 +0100)]
Missed to change one date in function.pl.

15 years agoChanged name of debugging macro (to avoid warning cause by multiple definition).
Jens Vollinga [Fri, 6 Feb 2009 15:24:58 +0000 (16:24 +0100)]
Changed name of debugging macro (to avoid warning cause by multiple definition).

15 years agoFixed returning of test result (++result was +result).
Jens Vollinga [Fri, 6 Feb 2009 15:22:58 +0000 (16:22 +0100)]
Fixed returning of test result (++result was +result).

15 years agoPrettified source code.
Jens Vollinga [Fri, 6 Feb 2009 15:07:10 +0000 (16:07 +0100)]
Prettified source code.

- Added copyright and GPL licencing to new files.
- Increased year to 2009.
- Changed guarding macros in header to uniform pattern without leading or
  trailing __ (double underscores).
- Put includes of system wide header consistently below own includes (help
  a tiny bit to clarify dependencies).

15 years agoFix chinese_remainder() so modular GCD actually works.
Alexei Sheplyakov [Fri, 6 Feb 2009 06:57:32 +0000 (08:57 +0200)]
Fix chinese_remainder() so modular GCD actually works.

15 years agoAutomake now needs to be version >=1.8. Older versions like 1.7.9 do not create
Jens Vollinga [Fri, 6 Feb 2009 12:13:06 +0000 (13:13 +0100)]
Automake now needs to be version >=1.8. Older versions like 1.7.9 do not create
the directory m4 in a VPATH build.

15 years agoRenamed files *.tcc and *.hpp to *.h.
Jens Vollinga [Thu, 5 Feb 2009 09:54:21 +0000 (10:54 +0100)]
Renamed files *.tcc and *.hpp to *.h.

15 years agoFixed compile errors introduced in previous commit
Jens Vollinga [Tue, 3 Feb 2009 12:50:33 +0000 (13:50 +0100)]
Fixed compile errors introduced in previous commit
45b1e47372090352ac5af655b32473df2abab23b.

15 years agoImplement modular multivariate GCD (based on chinese remaindering algorithm).
Alexei Sheplyakov [Mon, 19 Jan 2009 06:45:38 +0000 (08:45 +0200)]
Implement modular multivariate GCD (based on chinese remaindering algorithm).

Both algorithm and implementation are a bit inefficient:

* algorithm does not make use of sparseness of inputs (and most of
  multivariate polynomials are quite sparse)
* GiNaC's expressions are essentially immutable. Thus some simple
  operations (i.e. multiplying a polynomial by an element of the base ring)
  are prohibitively expensive.
* All numbers (i.e. GiNaC::numeric objects) are heap allocated.

Still it's much faster (~5x on bivariate polynomials, ~100x on 3-variate
ones) than (subresultant) PRS algorithm, so gcd() uses modular algorithm
by default.

15 years agoImprove (fix?) smod: now it really converts into symmetric representation...
Alexei Sheplyakov [Mon, 19 Jan 2009 06:44:36 +0000 (08:44 +0200)]
Improve (fix?) smod: now it really converts into symmetric representation...

... instead of clumsy convention inspirited by some proprietary CAS.

15 years agoFix copy-paste error in GINACLIB_MICRO_VERSION.
Alexei Sheplyakov [Mon, 19 Jan 2009 06:43:50 +0000 (08:43 +0200)]
Fix copy-paste error in GINACLIB_MICRO_VERSION.

15 years agoFixed bug in binomial(). binomial(n,0) erroneously returned 0.
Jens Vollinga [Thu, 8 Jan 2009 09:26:50 +0000 (10:26 +0100)]
Fixed bug in binomial(). binomial(n,0) erroneously returned 0.

15 years agoSmall fixes to avoid compile warnings (-Wall).
Jens Vollinga [Thu, 18 Dec 2008 11:19:35 +0000 (12:19 +0100)]
Small fixes to avoid compile warnings (-Wall).

15 years agoFixed bug in multivariate factorization. Fractional numerical content was not
Jens Vollinga [Thu, 18 Dec 2008 10:10:50 +0000 (11:10 +0100)]
Fixed bug in multivariate factorization. Fractional numerical content was not
extracted and led to a not so finite running behavior. Added new checks for that
bug.

Added static keywords to hide debugging output operators.

15 years agoAdded new items.
Jens Vollinga [Mon, 1 Dec 2008 09:26:38 +0000 (10:26 +0100)]
Added new items.

15 years ago[PATCH] [build] Simplify generation of ginac/version.h
Alexei Sheplyakov [Mon, 1 Dec 2008 09:13:12 +0000 (10:13 +0100)]
[PATCH] [build] Simplify generation of ginac/version.h

15 years ago[PATCH] Fix GiNaC library version information.
Alexei Sheplyakov [Mon, 1 Dec 2008 09:12:25 +0000 (10:12 +0100)]
[PATCH] Fix GiNaC library version information.

The libtool naming scheme cannot guarantee that on all systems, the numbering
is consecutive. It only guarantees that it is increasing. This doesn't matter,
though: there is not incurred cost for numbers that are omitted, except for
shrinking the available space of leftover numbers. Not something we need to
worry about yet.  ;-)  On the other hand, tricks which we were using to make
version numbers consecutive on GNU/Linux break versioning on other OSes.

15 years agoFixed a problem in polynomial divide by deactivating a recursion that lead to a
Jens Vollinga [Mon, 1 Dec 2008 08:54:53 +0000 (09:54 +0100)]
Fixed a problem in polynomial divide by deactivating a recursion that lead to a
significant slowdown in sqrfree() and sometimes to a infinite loop.

15 years agoAdded section about factor(). Made appropriate changes at other places.
Jens Vollinga [Fri, 14 Nov 2008 11:00:52 +0000 (12:00 +0100)]
Added section about factor(). Made appropriate changes at other places.

15 years agoAdded many comments.
Jens Vollinga [Thu, 13 Nov 2008 15:36:02 +0000 (16:36 +0100)]
Added many comments.

15 years agoFixed lots of bugs in factor_multivariate().
Jens Vollinga [Thu, 13 Nov 2008 10:13:05 +0000 (11:13 +0100)]
Fixed lots of bugs in factor_multivariate().

factor_univariate() takes now the content of the polynomial into accout when
choosing a prime. It also returns the chosen prime. This supports the
factor_multivariate() code.

Polynomials are expanded before calling factor_sqrfree(). This avoids problems
with some input polynomials.

Added static qualifiers to all hidden functions.

15 years agoFixed a bug in squarefree(). Some polynomials were erroneously classified as
Jens Vollinga [Tue, 11 Nov 2008 09:33:29 +0000 (10:33 +0100)]
Fixed a bug in squarefree(). Some polynomials were erroneously classified as
square free (e.g. x^prime+1).

Fixed a bug in multivar_diophant() causing  sporadically an infinite loop.

Improved lifting bound code.

Univariate lifting can now use a cache for the modular factors. At the moment,
this gives no measurable speed gain.

15 years agoAdded modular square free factorization.
Jens Vollinga [Mon, 10 Nov 2008 12:38:11 +0000 (13:38 +0100)]
Added modular square free factorization.
Completed distinct degree factorization.
Univariate polynomial factorization uses now upoly.
Merged class Partition and function split into class factor_partition.

15 years agoStupid error: did the revert on the wrong branch (master instead of ginac_1-4).
Jens Vollinga [Thu, 6 Nov 2008 13:18:01 +0000 (14:18 +0100)]
Stupid error: did the revert on the wrong branch (master instead of ginac_1-4).

Revert "Revert "[portability] GiNaC::compile_ex works on OpenBSD now.""

This reverts commit a6854a8a0f1e5db722320f5d7ccb9097053500cf.

15 years agoRevert "[portability] GiNaC::compile_ex works on OpenBSD now."
Jens Vollinga [Thu, 6 Nov 2008 13:13:54 +0000 (14:13 +0100)]
Revert "[portability] GiNaC::compile_ex works on OpenBSD now."

This reverts commit 375a7aa1f13fa6061c278eb2c2447fd91521b45d.

15 years agoUnivariate Hensel lifting now uses upoly.
Jens Vollinga [Thu, 6 Nov 2008 13:11:02 +0000 (14:11 +0100)]
Univariate Hensel lifting now uses upoly.
Changed q_matrix code.

15 years agoEquip ginac-examples.texi with directory entry for info.
Paul Irofti [Tue, 4 Nov 2008 14:55:34 +0000 (17:55 +0300)]
Equip ginac-examples.texi with directory entry for info.

15 years ago[portability] GiNaC::compile_ex works on OpenBSD now.
Alexei Sheplyakov [Mon, 3 Nov 2008 16:17:16 +0000 (19:17 +0300)]
[portability] GiNaC::compile_ex works on OpenBSD now.

* acinclude.m4: check for dlopen() in libdl and in libc itself.

Thanks to Paul Irofti for a bug report and a suggestion.

15 years ago[build] Set correct rpath for linking with CLN...
Alexei Sheplyakov [Mon, 3 Nov 2008 14:34:29 +0000 (17:34 +0300)]
[build] Set correct rpath for linking with CLN...

... so users won't get 'error while loading shared libraries: no such file
or directory'. Also embed rpath into pkg-config meta data, so

g++ `pkg-config --cflags --libs ginac` foo.cc

actually works without any additional effort from the user side.

15 years ago[bugfix] integer_cra: check if arguments contain at least 2 moduli
Alexei Sheplyakov [Thu, 23 Oct 2008 13:48:14 +0000 (17:48 +0400)]
[bugfix] integer_cra: check if arguments contain at least 2 moduli

While at it, also fix exam_cra so it does not produce pointless inputs.

15 years agoexam_cra: explicitly #include <limits>. This should make g++ 4.3 happy.
Alexei Sheplyakov [Tue, 21 Oct 2008 06:09:33 +0000 (10:09 +0400)]
exam_cra: explicitly #include <limits>. This should make g++ 4.3 happy.

15 years agoChanged debugging facilities in factor.cpp.
Jens Vollinga [Wed, 5 Nov 2008 12:56:53 +0000 (13:56 +0100)]
Changed debugging facilities in factor.cpp.

15 years agoFixed some minor spelling errors.
Jens Vollinga [Wed, 5 Nov 2008 10:31:35 +0000 (11:31 +0100)]
Fixed some minor spelling errors.

15 years agoChanged code from using cl_UP_MI to using umodpoly. The cl_UP_MI interface was
Jens Vollinga [Wed, 5 Nov 2008 10:22:19 +0000 (11:22 +0100)]
Changed code from using cl_UP_MI to using umodpoly. The cl_UP_MI interface was
inconvenient to use and caused several very difficult bugs (some were still
unresolved before changing to umodpoly!).

Fixed severe bug in multivariate factorization. The condition that all modular
factors should be relatively prime in the base ring was violated. This caused
the factorization sometimes to go into an infinite loop.

16 years agoAdded code for distinct degree factorization.
Jens Vollinga [Mon, 3 Nov 2008 14:50:31 +0000 (15:50 +0100)]
Added code for distinct degree factorization.

16 years agotutorial: simplify the instructions on writing extension classes.
Alexei Sheplyakov [Sun, 19 Oct 2008 16:21:33 +0000 (20:21 +0400)]
tutorial: simplify the instructions on writing extension classes.

Don't mention (un)archiving while describing the `mystring' class
(the minimalistic extension class), so readers have less chances to get
confused.

16 years agoDon't force every algebraic class to implement archiving/unarchiving.
Alexei Sheplyakov [Sun, 19 Oct 2008 15:39:30 +0000 (19:39 +0400)]
Don't force every algebraic class to implement archiving/unarchiving.

So people who don't use (un)archiving don't need to bother with it.

16 years agotutorial: don't mention custom RTTI any more (as it does not exist).
Alexei Sheplyakov [Fri, 17 Oct 2008 13:57:27 +0000 (17:57 +0400)]
tutorial: don't mention custom RTTI any more (as it does not exist).

16 years agosymbol: make get_domain() a virtual method, remove symbol::domain.
Alexei Sheplyakov [Thu, 16 Oct 2008 11:43:32 +0000 (15:43 +0400)]
symbol: make get_domain() a virtual method, remove symbol::domain.

This cuts yet another 4 bytes from GiNaC::symbol. While at it, fix a memory
leak in ginsh.

16 years agosymbol: don't bother to set TeX name if user did not specified one.
Alexei Sheplyakov [Thu, 16 Oct 2008 11:43:32 +0000 (15:43 +0400)]
symbol: don't bother to set TeX name if user did not specified one.

Same for the usual name. As a result we use less memory (and the output
is exactly the same).

16 years agosymbol: remove return_type_tinfo() and return_type() (shrink symbol by 8 bytes)
Alexei Sheplyakov [Fri, 17 Oct 2008 10:56:54 +0000 (14:56 +0400)]
symbol: remove return_type_tinfo() and return_type() (shrink symbol by 8 bytes)

Bloating symbol to the state sizeof(symbol) == 64 is not appreciated at all.
If someone needs/wants non-commutative symbols or other fancy stuff, please
derive from class symbol and do whatever you want.

16 years agoWipe out remnants of custom RTTI.
Alexei Sheplyakov [Fri, 17 Oct 2008 09:41:01 +0000 (13:41 +0400)]
Wipe out remnants of custom RTTI.

Custom RTTI considered harmful, final part.

16 years agoregistered_class_info: use typeid() instead of tinfo_static.
Alexei Sheplyakov [Wed, 15 Oct 2008 11:32:11 +0000 (15:32 +0400)]
registered_class_info: use typeid() instead of tinfo_static.

(Custom RTTI considered harmful, part 5).

Since custom RTTI is going to be removed, registered_class_info needs to be
re-organazied. Now tinfo_key is a (const) pointer to std::type_info.

16 years agoA better return_type_tinfo() mechanism.
Alexei Sheplyakov [Fri, 17 Oct 2008 09:15:03 +0000 (13:15 +0400)]
A better return_type_tinfo() mechanism.

return_type_tinfo() is used in order to distingish between non-commutative
objects of different type. However, often it's necessary to distingish
between non-commutative objects of the same type, for example, between
gamma matrices with different representation label. return_type_tinfo()
does not provide any clean way to do that. Hence, introduce return_type_t
type which holds representation label along with type information, and
use it for return_type_tinfo().

16 years agocalchash(): use type_info::name() instead of tinfo().
Alexei Sheplyakov [Wed, 15 Oct 2008 11:32:11 +0000 (15:32 +0400)]
calchash(): use type_info::name() instead of tinfo().

Custom RTTI considered harmful, part 4.

The hash value of the object of different types should be different whenever
possible. Hence calcash() needs a unique per type number. Previously we used
tinfo_key for this. typeinfo::name() (a *pointer* to implementation dependent
string) is also unique for each class, so it's just as good as tinfo() is.

16 years agoindexed::eval: use standard C++ RTTI.
Alexei Sheplyakov [Wed, 15 Oct 2008 11:32:11 +0000 (15:32 +0400)]
indexed::eval: use standard C++ RTTI.

Custom RTTI considered harmful, part 3.

16 years agobasic, expairseq: use standard C++ RTTI in compare(), is_equal(), match(), etc.
Alexei Sheplyakov [Wed, 15 Oct 2008 11:32:11 +0000 (15:32 +0400)]
basic, expairseq: use standard C++ RTTI in compare(), is_equal(), match(), etc.

Custom RTTI considered harmful, part 2.

* basic.cpp: use standard C++ RTTI in compare(), is_equal(), operator=(),
  match().
* expairseq.cpp: use standard C++ RTTI in match(), make_flat(),
  construct_from_2_ex().

16 years agois_exactly_a: use typeid() to check the type of expression.
Alexei Sheplyakov [Wed, 15 Oct 2008 11:32:11 +0000 (15:32 +0400)]
is_exactly_a: use typeid() to check the type of expression.

Custom RTTI considered harmful, part 1.

Custom run time type information (RTTI) system implemented in GiNaC have
several serious drawbacks, such as

1. It makes writing GiNaC classes unnecessary cumbersome.
2. It wastes sizeof(void *) bytes per object, for small objects like
   symbol, numeric, etc. this overhead is considerable.

It turns out that GiNaC's RTTI is not any faster than the standard one
(at least on GNU/Linux and Solaris with GNU C++ library and compiler).
So, GiNaC RTTI have no reasons to exit any more.

16 years agoptr.h: use unsigned int to store reference counts (in order to save memory).
Alexei Sheplyakov [Wed, 15 Oct 2008 06:16:07 +0000 (10:16 +0400)]
ptr.h: use unsigned int to store reference counts (in order to save memory).

We'll hardly ever get more than 2^32 references to the same object. So using
size_t to store reference count only wastes 4 bytes per object (on 64-bit
architecture). Use unsigned int instead.

16 years agoRewritten heuristic and PRS GCD for univariate polynomials, added benchmark.
Alexei Sheplyakov [Sun, 19 Oct 2008 17:27:14 +0000 (21:27 +0400)]
Rewritten heuristic and PRS GCD for univariate polynomials, added benchmark.

Using a better data structure for univariate polynomials makes GCD 10 -- 300
times faster (and less memory hungry).

16 years agopolynomial: introduce a helper function to divide polynomial by ring element.
Alexei Sheplyakov [Tue, 14 Oct 2008 06:44:07 +0000 (10:44 +0400)]
polynomial: introduce a helper function to divide polynomial by ring element.

16 years agomod_gcd: naive hack to chose a 'good' prime (to speed up gcd computation).
Alexei Sheplyakov [Tue, 14 Oct 2008 06:37:42 +0000 (10:37 +0400)]
mod_gcd: naive hack to chose a 'good' prime (to speed up gcd computation).

16 years ago[bugfix] remainder_in_ring: using exact division is plain wrong.
Alexei Sheplyakov [Mon, 29 Sep 2008 05:58:35 +0000 (09:58 +0400)]
[bugfix] remainder_in_ring: using exact division is plain wrong.

16 years ago[bugfix] normalize_in_ring: don't set the leading coefficient to 1.
Alexei Sheplyakov [Mon, 29 Sep 2008 05:53:46 +0000 (09:53 +0400)]
[bugfix] normalize_in_ring: don't set the leading coefficient to 1.

The coefficient ring is not a field, so the leading coefficient don't
have to be 1.

16 years ago[trivial] excompiler.cpp: shut up some silly compiler warnings.
Alexei Sheplyakov [Thu, 25 Sep 2008 09:19:57 +0000 (13:19 +0400)]
[trivial] excompiler.cpp: shut up some silly compiler warnings.

GCC warns about 'comparison between signed and unsigned integer expressions'.
In this case such comparison is harmless, but still it's a bit annoying.

16 years agoMerge branch 'master' of git://ffmssmsc.jinr.ru:443/varg/ginac
Jens Vollinga [Tue, 30 Sep 2008 09:47:25 +0000 (11:47 +0200)]
Merge branch 'master' of git://ffmssmsc.jinr.ru:443/varg/ginac

16 years agoReplaced class UniPoly by cl_UP_MI.
Jens Vollinga [Mon, 29 Sep 2008 15:38:46 +0000 (17:38 +0200)]
Replaced class UniPoly by cl_UP_MI.

16 years ago- Added options argument to factor(). Added flag factor_options::all that lets
Jens Vollinga [Fri, 26 Sep 2008 09:07:02 +0000 (11:07 +0200)]
- Added options argument to factor(). Added flag factor_options::all that lets
  factor() act on all polynomial subexpressions.
- Added more comments.

16 years agoImplemented modular GCD algorithm for univariate polynomials.
Alexei Sheplyakov [Sat, 20 Sep 2008 19:18:46 +0000 (23:18 +0400)]
Implemented modular GCD algorithm for univariate polynomials.

16 years agoWipe out the old (bison/flex generated) parser.
Alexei Sheplyakov [Sun, 14 Sep 2008 03:13:01 +0000 (07:13 +0400)]
Wipe out the old (bison/flex generated) parser.

Bison generated parser has a number of problems:

1. Bad performance. Parsing a sum seems to be O(N^{2 + a}) (a > 0).
   For example, parsing a sum (actually, a univariate polynomial) of 32768
   terms takes about 90 sec. on my box, parsing a sum of 10^6 terms takes
   "eternity".
2. The user is expected to provide list of all symbols in the expression.
   Often this is very annoying (and useless), sometimes it is not possible
   at all.
3. Parser is not reentrant (bison *can* produce reentrant parsers, but that
   won't solve other problems).
4. Parser is difficult to extend.

Since the new parser handles almost everything (useful) as the old one, let's
remove the latter.

16 years agocheck: time_parser.cpp: don't run the same benchmark twice.
Alexei Sheplyakov [Sun, 14 Sep 2008 02:57:21 +0000 (06:57 +0400)]
check: time_parser.cpp: don't run the same benchmark twice.

Since ex(const string&, lst&) ctor uses the new parser now comparing its
performance (and result) with one of direct invocation of the parser is
pointless.

16 years agoDocument the new parser, provide an example.
Alexei Sheplyakov [Sun, 14 Sep 2008 02:41:12 +0000 (06:41 +0400)]
Document the new parser, provide an example.